Skip to content

Add support for rendering BigInt #24580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 26, 2024
Merged

Add support for rendering BigInt #24580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c337aab
bigint-tests
eps1lon May 18, 2022
6b9174f
f test
Feb 18, 2024
2217076
bigint-render-impl
eps1lon May 18, 2022
1c1b6aa
Add case to devtools fixture
Feb 17, 2024
5ffd3fc
bigint tests for input values
Feb 18, 2024
46e5e92
bigint impl for input values
Feb 18, 2024
aa56850
bigint test for title children
Feb 18, 2024
8075e41
bigint impl for title children
Feb 18, 2024
1011269
Add feature flag for experimental release channel
Feb 18, 2024
111ff28
Ungate already passing tests
Feb 18, 2024
ad6e64f
Schedule BigInt support for next major
Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ungate already passing tests
  • Loading branch information
Sebastian Silbermann committed Feb 26, 2024
commit 111ff2844de4e8e22f9cea13140e9d1f076e0cdb
1 change: 0 additions & 1 deletion packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5680,7 +5680,6 @@ describe('ReactDOMFizzServer', () => {
expect(getVisibleChildren(document.head)).toEqual(<title>4</title>);
});

// @gate enableBigIntSupport
it('should accept a single bigint child', async () => {
// a Single number child
function App() {
Expand Down
2 changes: 0 additions & 2 deletions packages/react-dom/src/__tests__/ReactDOMInput-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,6 @@ describe('ReactDOMInput', () => {
expect(div.firstChild.getAttribute('defaultValue')).toBe(null);
});

// @gate enableBigIntSupport
it('should render bigint defaultValue for SSR', () => {
const markup = ReactDOMServer.renderToString(
<input type="text" defaultValue={5n} />,
Expand All @@ -677,7 +676,6 @@ describe('ReactDOMInput', () => {
expect(div.firstChild.getAttribute('defaultValue')).toBe(null);
});

// @gate enableBigIntSupport
it('should render bigint value for SSR', () => {
const element = <input type="text" value={5n} onChange={() => {}} />;
const markup = ReactDOMServer.renderToString(element);
Expand Down