Skip to content

[eslint-plugin-react-hooks] only allow capitalized component names #25162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2022
Merged

[eslint-plugin-react-hooks] only allow capitalized component names #25162

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfee9e6
[eslint-plugin-react-hooks] add test showing broken behavior
kassens Aug 31, 2022
f95ad03
[eslint-plugin-react-hooks] update naming rules to disallow _component
kassens Aug 31, 2022
2c54215
clarify changelog
kassens Aug 31, 2022
a29812e
update CHANGELOG to remind us the next release is a major
kassens Aug 31, 2022
f426964
update eslint-plugin-react-hooks version
kassens Sep 1, 2022
bd5763e
Merge branch 'main' of https://github.com/facebook/react into hook-na…
kassens Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[eslint-plugin-react-hooks] add test showing broken behavior
  • Loading branch information
@kassens
kassens committed Aug 31, 2022
commit cfee9e621f0fbf4e33e19b99d261204e11953dea
11 changes: 11 additions & 0 deletions packages/eslint-plugin-react-hooks/__tests__/ESLintRulesOfHooks-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,17 @@ const tests = {
const [myState, setMyState] = useState(null);
}
`,
`
// Valid, but should be invalid. '_useHook' is currently recognized as a component.
function Component(props) {
if (cond) {
_useHook();
}
}
function _useHook() {
useState(null);
}
`,
],
invalid: [
{
Expand Down