Skip to content

Fix logic around attribute seralization #26526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix logic around attribute seralization #26526

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f730469
fix logic around attribute seralization
gnoff Mar 31, 2023
f3b9f31
cleanup
gnoff Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup
  • Loading branch information
@gnoff
gnoff committed Mar 31, 2023
commit f3b9f31783328ee85cd3739e206b559835c7e09f
22 changes: 12 additions & 10 deletions packages/react-dom-bindings/src/server/ReactDOMServerFormatConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3926,22 +3926,22 @@ function writeStyleResourceAttributeInJS(
return;

// Attribute renames
case 'className':
case 'className': {
attributeName = 'class';
if (__DEV__) {
checkAttributeStringCoercion(value, attributeName);
}
attributeValue = '' + (value: any);
break;

}
// Booleans
case 'hidden':
case 'hidden': {
if (value === false) {
return;
}
attributeValue = '';
break;

}
// Santized URLs
case 'src':
case 'href': {
Expand All @@ -3954,8 +3954,8 @@ function writeStyleResourceAttributeInJS(
}
default: {
if (
// shouldIgnoreAttribute
// We have already filtered out null/undefined and reserved words.
// unrecognized event handlers are not SSR'd and we (apparently)
// use on* as hueristic for these handler props
name.length > 2 &&
(name[0] === 'o' || name[0] === 'O') &&
(name[1] === 'n' || name[1] === 'N')
Expand Down Expand Up @@ -4122,21 +4122,23 @@ function writeStyleResourceAttributeInAttr(
return;

// Attribute renames
case 'className':
case 'className': {
attributeName = 'class';
if (__DEV__) {
checkAttributeStringCoercion(value, attributeName);
}
attributeValue = '' + (value: any);
break;
}

// Booleans
case 'hidden':
case 'hidden': {
if (value === false) {
return;
}
attributeValue = '';
break;
}

// Santized URLs
case 'src':
Expand All @@ -4150,8 +4152,8 @@ function writeStyleResourceAttributeInAttr(
}
default: {
if (
// shouldIgnoreAttribute
// We have already filtered out null/undefined and reserved words.
// unrecognized event handlers are not SSR'd and we (apparently)
// use on* as hueristic for these handler props
name.length > 2 &&
(name[0] === 'o' || name[0] === 'O') &&
(name[1] === 'n' || name[1] === 'N')
Expand Down