Skip to content

Add nonce support to bootstrap scripts and external runtime #26738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 1, 2023
Merged

Add nonce support to bootstrap scripts and external runtime #26738

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
715fe00
Add nonce support for src and module scripts
danieltott Apr 27, 2023
3eb1605
prettier
danieltott Apr 27, 2023
1568a43
clarify test title
danieltott Apr 27, 2023
1f96d21
update attribute order
danieltott Apr 27, 2023
90a10e5
add nonce test to FizzServerBrowser test
danieltott Apr 27, 2023
0031469
make sure to add nonce back to script if it exists
danieltott Apr 28, 2023
2647b84
pass nonce prop to the runtime script
danieltott Apr 28, 2023
f3d98d3
add test for nonce support
danieltott Apr 28, 2023
5b76f96
Update legacy typing
danieltott Apr 28, 2023
89ce5ad
Add nonce for rendered scripts
danieltott Apr 28, 2023
afb6d38
reorder test
danieltott Apr 28, 2023
d5c6bd2
Update test to use async for some scripts
danieltott Apr 28, 2023
b1b1940
Fix inline script content
danieltott Apr 28, 2023
dc3ceba
use static-dynamic-static sandwich style 🥪
danieltott Apr 28, 2023
bb21ba7
Remove automatic nonce-adding to rendered scripts
danieltott Apr 28, 2023
ceb387b
Merge branch 'facebook:main' into nonce-scripts
danieltott Apr 28, 2023
d2d41c4
Update computation of script chunks
danieltott Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make sure to add nonce back to script if it exists
  • Loading branch information
@danieltott
danieltott committed Apr 28, 2023
commit 003146934b8966aaa6cbdadb9c60992f0569f797
6 changes: 6 additions & 0 deletions packages/react-dom/src/test-utils/FizzTestUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ async function executeScript(script: Element) {
} else {
const newScript = ownerDocument.createElement('script');
newScript.textContent = script.textContent;
// make sure to add nonce back to script if it exists
const scriptNonce = script.getAttribute('nonce');
if (scriptNonce) {
newScript.setAttribute('nonce', scriptNonce);
}

parent.insertBefore(newScript, script);
parent.removeChild(script);
}
Expand Down