Compare name when hydrating hidden fields to filter out extra form action fields #26846
+67
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
gnoff
approved these changes
May 24, 2023
Collaborator
gnoff
left a comment
gnoff
left a comment
There was a problem hiding this comment.
yes getting quite specific. Since these fields are implementation details and not really in the purview of app authors maybe this is a case where we do some data attribute to mark skippable. won't really make the code smaller and will make payloads slightly bigger but makes the comparison feel less arbitrarily specific
sebmarkbage
force-pushed
the
hydratehidden
branch
3 times, most recently
from
7a054c9 to
9622750
Compare
sebmarkbage
force-pushed
the
hydratehidden
branch
from
9622750 to
f216bac
Compare
|
Comparing: 4daccad...f216bac Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…tion fields (facebook#26846) This solves an issue where if you inject a hidden field in the beginning of the form, we might mistakenly hydrate the injected one that was part of an action. I'm not too happy about how specific this becomes. It's similar to Float but in general we don't do this deep comparison. See vercel/next.js#50087
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
…tion fields (#26846) This solves an issue where if you inject a hidden field in the beginning of the form, we might mistakenly hydrate the injected one that was part of an action. I'm not too happy about how specific this becomes. It's similar to Float but in general we don't do this deep comparison. See vercel/next.js#50087 DiffTrain build for commit a1f9758.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue where if you inject a hidden field in the beginning of the form, we might mistakenly hydrate the injected one that was part of an action.
I'm not too happy about how specific this becomes. It's similar to Float but in general we don't do this deep comparison.
See vercel/next.js#50087