Skip to content

[Fizz] Track postponed holes in the prerender pass #27317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 31, 2023
Merged

[Fizz] Track postponed holes in the prerender pass #27317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
57488c6
Fix Node Server export names
sebmarkbage Aug 29, 2023
d814510
Add trackedPostpones field
sebmarkbage Aug 28, 2023
9286b09
Return postponed state when some postponed were tracked
sebmarkbage Aug 28, 2023
5e4869f
Add basic tests
sebmarkbage Aug 29, 2023
d58d26d
Track the key path on the SuspenseBoundary
sebmarkbage Aug 29, 2023
3f0874a
Track postponed holes
sebmarkbage Aug 29, 2023
e8c8152
Encode postponed holes into a resumable path tree
sebmarkbage Aug 30, 2023
e96bb09
Eagerly assign ids to postponed segments or boundaries
sebmarkbage Aug 30, 2023
019dd90
Eagerly encode the serializable nodes
sebmarkbage Aug 30, 2023
7733a15
Gate test
sebmarkbage Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Gate test
  • Loading branch information
@sebmarkbage
sebmarkbage committed Aug 31, 2023
commit 7733a1570f97ea4cc6cefc00a868ddd2de7c3ca7
2 changes: 1 addition & 1 deletion packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6193,7 +6193,7 @@ describe('ReactDOMFizzServer', () => {
},
);

// @gate experimental
// @gate enablePostpone
it('supports postponing in prerender and resuming later', async () => {
let prerendering = true;
function Postpone() {
Expand Down
4 changes: 2 additions & 2 deletions packages/react-dom/src/__tests__/ReactDOMFizzStaticBrowser-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ describe('ReactDOMFizzStaticBrowser', () => {
expect(errors).toEqual(['uh oh', 'uh oh']);
});

// @gate experimental
// @gate enablePostpone
it('supports postponing in prerender and resuming later', async () => {
let prerendering = true;
function Postpone() {
Expand Down Expand Up @@ -493,7 +493,7 @@ describe('ReactDOMFizzStaticBrowser', () => {
// TODO: expect(getVisibleChildren(container)).toEqual(<div>Hello</div>);
});

// @gate experimental
// @gate enablePostpone
it('only emits end tags once when resuming', async () => {
let prerendering = true;
function Postpone() {
Expand Down