Skip to content

Ensure useState and useReducer initializer functions are double invoked in StrictMode #28248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 6, 2024
+53 −1
Merged

Ensure useState and useReducer initializer functions are double invoked in StrictMode #28248

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6596c5c
Ensure useState and useReducer initializer functions are double invok…
Feb 5, 2024
c40cd29
Fix Flow
Feb 5, 2024
69abbc5
buff up wording
Feb 5, 2024
f6d0c63
Ensure second invocation is dimmed
Feb 5, 2024
3b83783
No try-finally for consistency
Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
buff up wording
  • Loading branch information
Sebastian Silbermann committed Feb 5, 2024
commit 69abbc56f693239cf63f92d26d334906084f7cf0
12 changes: 6 additions & 6 deletions packages/react/src/__tests__/ReactStrictMode-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,14 @@ describe('ReactStrictMode', () => {

function App() {
React.useState(() => {
log.push('Compute initial count state: 1');
log.push('Compute initial state count: 1');
return 1;
});
React.useReducer(
s => s,
2,
s => {
log.push('Compute initial reducer state: 2');
log.push('Compute initial reducer count: 2');
return s;
},
);
Expand All @@ -235,10 +235,10 @@ describe('ReactStrictMode', () => {
expect(container.textContent).toBe('3');

expect(log).toEqual([
'Compute initial count state: 1',
'Compute initial count state: 1',
'Compute initial reducer state: 2',
'Compute initial reducer state: 2',
'Compute initial state count: 1',
'Compute initial state count: 1',
'Compute initial reducer count: 2',
'Compute initial reducer count: 2',
]);
});

Expand Down