Skip to content

Remove usage of ReactTestUtils from ReactContextValidator #28329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Remove usage of ReactTestUtils from ReactContextValidator #28329

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
756373f
Remove usage of ReactTestUtils from ReactContextValidator
Feb 14, 2024
e270e1e
Update error messages
Feb 14, 2024
dff0b81
Restore comments
Feb 14, 2024
9baf9d3
Update packages/react/src/__tests__/ReactContextValidator-test.js
eps1lon Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore comments
  • Loading branch information
Sebastian Silbermann committed Feb 14, 2024
commit dff0b812edb128c984e3fc70c674c7037ebf4c38
2 changes: 2 additions & 0 deletions packages/react/src/__tests__/ReactContextValidator-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ describe('ReactContextValidator', () => {
'getChildContext() on ComponentA or remove childContextTypes from it.',
);

// Warnings should be deduped by component typ
let container = document.createElement('div');
let root = ReactDOMClient.createRoot(container);
await act(() => {
Expand Down Expand Up @@ -439,6 +440,7 @@ describe('ReactContextValidator', () => {
'The legacy contextTypes property will be ignored.',
);

// Warnings should be deduped by component type
let container = document.createElement('div');
let root = ReactDOMClient.createRoot(container);
await act(() => {
Expand Down