[compiler] Refactor makeTemporary outside HIRBuilder #30545
Merged
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a useful utility function similar to the existing `makeInstructionId` and `makeIdentifierId` functions. This PR moves it outside the HIRBuilder so we can use this in passes that don't have access to the builder instance. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 31, 2024
facebook-github-bot
added
the
React Core Team
| loc, | ||
| }; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
just a heads up that we also have createTemporaryPlace() which we could maybe unify
Contributor
Author
There was a problem hiding this comment.
will do this in a follow up!
josephsavona
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is a useful utility function similar to the existing
makeInstructionIdandmakeIdentifierIdfunctions.This PR moves it outside the HIRBuilder so we can use this in passes
that don't have access to the builder instance.