[Flight] Implement prerender #30686
Merged
[Flight] Implement prerender #30686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
gnoff
force-pushed
the
flight-prerender
branch
from
47c1a7e to
a7f5151
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
a7f5151 to
3f04b24
Compare
gnoff
force-pushed
the
flight-prerender
branch
2 times, most recently
from
76400c0 to
e8d40ea
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
e8d40ea to
2d4f940
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
2d4f940 to
b90b9a1
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
b90b9a1 to
f77261b
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
f77261b to
76e6197
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
76e6197 to
ec7898e
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
ec7898e to
89b82fc
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
89b82fc to
6f5eab2
Compare
gnoff
force-pushed
the
flight-prerender
branch
from
6f5eab2 to
0a55ade
Compare
sebmarkbage
approved these changes
Aug 15, 2024
| logRecoverableError(request, error, null); | ||
| fatalError(request, error); | ||
| } finally { | ||
| if (request.abortableTasks.size === 0) { |
Collaborator
There was a problem hiding this comment.
This should be inside the catch.
Prerendering in flight is similar to prerendering in Fizz. Instead of receiving a result (the stream) immediately a promise is returned which resolves to the stream when the prerender is complete. The promise will reject if the flight render fatally errors otherwise it will resolve when the render is completed or is aborted.
gnoff
force-pushed
the
flight-prerender
branch
from
0a55ade to
4900980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerendering in flight is similar to prerendering in Fizz. Instead of receiving a result (the stream) immediately a promise is returned which resolves to the stream when the prerender is complete. The promise will reject if the flight render fatally errors otherwise it will resolve when the render is completed or is aborted.