Skip to content

fix: restore selection should consider the window of the container #30951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2024
Merged

fix: restore selection should consider the window of the container #30951

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f999e70
fix: restore selection should consider the window of the container
ling1726 Sep 12, 2024
c8f573e
revert ReactVersion.js change
ling1726 Sep 13, 2024
edd9d8a
Apply suggestion for optional chainng
ling1726 Sep 13, 2024
e545af8
add test
ling1726 Sep 13, 2024
6a6b952
restoreSelection should be called with containerInfo
ling1726 Sep 13, 2024
9e79394
suggestions
ling1726 Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restoreSelection should be called with containerInfo
  • Loading branch information
@ling1726
ling1726 committed Sep 13, 2024
commit 6a6b952765c6e017ae4df5f8590aa78d0fe3ba77
2 changes: 1 addition & 1 deletion packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ export function afterActiveInstanceBlur(): void {
}

export function resetAfterCommit(containerInfo: Container): void {
restoreSelection(selectionInformation);
restoreSelection(selectionInformation, containerInfo);
ReactBrowserEventEmitterSetEnabled(eventsEnabled);
eventsEnabled = null;
selectionInformation = null;
Expand Down