Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
disable enableSiblingPrerendering in experimental channel
Disables `enableSiblingPrerendering` in the experimental builds until the feature is tested at Meta first.
  • Loading branch information
gnoff committed Sep 12, 2024
commit 3c515e48814b8214c35d53ded9e81fd6f60ebfb4
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ import semver from 'semver';
// TODO: This is how other DevTools tests access the version but we should find
// a better solution for this
const ReactVersionTestingAgainst = process.env.REACT_VERSION || ReactVersion;
const enableSiblingPrerendering = semver.gte(
ReactVersionTestingAgainst,
'19.0.0',
);
// Disabling this while the flag is off in experimental. Leaving the logic so we can
// restore the behavior when we turn the flag back on.
const enableSiblingPrerendering =
false && semver.gte(ReactVersionTestingAgainst, '19.0.0');

describe('Timeline profiler', () => {
let React;
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/ReactFeatureFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const enableOwnerStacks = __EXPERIMENTAL__;

export const enableShallowPropDiffing = false;

export const enableSiblingPrerendering = __EXPERIMENTAL__;
export const enableSiblingPrerendering = false;

/**
* Enables an expiration time for retry lanes to avoid starvation.
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/forks/ReactFeatureFlags.test-renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const enableAddPropertiesFastPath = false;

export const renameElementSymbol = true;
export const enableShallowPropDiffing = false;
export const enableSiblingPrerendering = __EXPERIMENTAL__;
export const enableSiblingPrerendering = false;

// TODO: This must be in sync with the main ReactFeatureFlags file because
// the Test Renderer's value must be the same as the one used by the
Expand Down