-
Notifications
You must be signed in to change notification settings - Fork 49.8k
[DevTools] Use Popover API for TraceUpdates highlighting #32614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hoxyq
merged 9 commits into
facebook:main
from
yongsk0066:feature/devtools-toplayer-highlight
May 7, 2025
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ecb403f
[DevTools] Use Popover API for TraceUpdates highlighting
yongsk0066 a83589c
[DevTools] Improve TraceUpdates popover behavior
yongsk0066 9215664
[DevTools] Fix Flow type errors for TraceUpdates popover implementation
yongsk0066 f7eb1c6
[DevTools] Raise minimum Chrome version to 114 for Popover API support
yongsk0066 938ad0e
[DevTools] Add explanatory comments to $FlowFixMe annotations for Pop…
yongsk0066 9c21b1e
[DevTools] Removed unnecessary try-catch blocks around Popover API me…
yongsk0066 6893d25
[DevTools] Improve TraceUpdates popover layering behavior
yongsk0066 862826b
[DevTools] Add TraceUpdatesTest component for manual testing
yongsk0066 c950b0d
[DevTools] Add Flow annotations for TraceUpdates implementation
yongsk0066 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[DevTools] Removed unnecessary try-catch blocks around Popover API me…
…thod calls in the TraceUpdates canvas implementation.
- Loading branch information
commit 9c21b1e9cd563bb45f730db6d10b751ff97a1b36
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.