Skip to content

[mcp] Add proper web-vitals metric collection #33109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025
Merged

[mcp] Add proper web-vitals metric collection #33109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad63721
[mcp] Add proper web-vitals metric collection
jorge-cab May 2, 2025
7cce862
[mcp] Revert left over changes from merge hell
jorge-cab May 2, 2025
fa03b19
formatting
jorge-cab May 2, 2025
ece6103
Address comments
jorge-cab May 5, 2025
ba3c9e0
Gracefully handle failures when programmatically clicking DOM elements
jorge-cab May 6, 2025
d3cdd82
format
jorge-cab May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comments
  • Loading branch information
@jorge-cab
jorge-cab committed May 5, 2025
commit ece61036574284454476f3b4c3de17c581763d11
1 change: 0 additions & 1 deletion compiler/packages/react-mcp-server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,6 @@ server.tool(
## Mean Render Time
${calculateMean(results.renderTime)}

TEST: ${results.webVitals.inp}
## Mean Web Vitals
- Cumulative Layout Shift (CLS): ${calculateMean(results.webVitals.cls)}
- Largest Contentful Paint (LCP): ${calculateMean(results.webVitals.lcp)}
Expand Down
6 changes: 2 additions & 4 deletions compiler/packages/react-mcp-server/src/tools/runtimePerf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,8 @@ export async function measurePerformance(
return window.__INTERACTABLE_SELECTORS__;
});

for (const selector of selectors) {
await page.click(selector);
await delay(500);
}
await Promise.all(selectors.map(selector => page.click(selector)));
await delay(500);

// Visit a new page for 1s to background the current page so that WebVitals can finish being calculated
const tempPage = await browser.newPage();
Expand Down
Loading