Skip to content

Conversation

@zpao
Copy link
Member

@zpao zpao commented Jul 21, 2015

5.7 and 5.8 are having issues with linting and I don't want to deal with that.

5.7 and 5.8 are having big issues with linting
@bgw
Copy link
Contributor

bgw commented Jul 21, 2015

@troutowicz
Copy link
Contributor

I was experiencing issues with disabling linting for blocks of code using /*eslint-disable */, ended up being babel-core that needed locking @ 5.6.x, the latest version of the other babel packages worked fine.

@zpao
Copy link
Member Author

zpao commented Jul 21, 2015

A bunch of other things are broken though (looks like a lot of comment-related issues, but haven't looked into it).
screen shot 2015-07-21 at 1 21 48 pm
(there are a couple unrelated things in there due to local untracked files)

@bgw
Copy link
Contributor

bgw commented Jul 21, 2015

Okay, I guess we can merge this then.

@sophiebits
Copy link
Collaborator

(cc @sebmck)

zpao added a commit that referenced this pull request Jul 21, 2015
@zpao zpao merged commit e928c65 into facebook:master Jul 21, 2015
@sebmck
Copy link
Contributor

sebmck commented Jul 21, 2015

Looking into it.

sebmck added a commit to babel/babel-eslint that referenced this pull request Jul 21, 2015
@sebmck
Copy link
Contributor

sebmck commented Jul 21, 2015

Found it. Comment attachment was recently integrated into Babel's parser for performance, Babel uses the comment node type CommentBlock, while ESLint uses Block which causes it to ignore the comments due to the node type difference. I've added a fix to babel-eslint and released it as v3.1.24.

@bgw
Copy link
Contributor

bgw commented Jul 21, 2015

Wow. That was fast. Thanks @sebmck.

@zpao
Copy link
Member Author

zpao commented Jul 21, 2015

Since others are referring here, there's still a problem with comments so we'll stay at 5.6 for a bit longer. babel/babel-eslint#153

@sebmck
Copy link
Contributor

sebmck commented Jul 22, 2015

Fixed the remaining comment issues and added regression tests to ensure it wont happen again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants