-
Notifications
You must be signed in to change notification settings - Fork 49.8k
Lock babel @ 5.6.x. #4449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock babel @ 5.6.x. #4449
Conversation
5.7 and 5.8 are having big issues with linting
|
I was experiencing issues with disabling linting for blocks of code using |
|
Okay, I guess we can merge this then. |
|
(cc @sebmck) |
|
Looking into it. |
|
Found it. Comment attachment was recently integrated into Babel's parser for performance, Babel uses the comment node type |
|
Wow. That was fast. Thanks @sebmck. |
|
Since others are referring here, there's still a problem with comments so we'll stay at 5.6 for a bit longer. babel/babel-eslint#153 |
|
Fixed the remaining comment issues and added regression tests to ensure it wont happen again in the future. |

5.7 and 5.8 are having issues with linting and I don't want to deal with that.