Skip to content

[Fiber] New error boundary semantics #8304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 1, 2016
Merged

[Fiber] New error boundary semantics #8304

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7967679
New error boundary semantics
acdlite Nov 16, 2016
88be836
Fix broken setState callback test
acdlite Nov 16, 2016
69796b3
Exit early in scheduleUpdate if a node's priority matches
acdlite Nov 12, 2016
614cd4b
Add test for "unwinding" context when an error interrupts rendering
acdlite Nov 17, 2016
4f126f5
Switch over primary effect types only
acdlite Nov 17, 2016
a61de42
Only continue the work loop if the error was successfully captured
acdlite Nov 17, 2016
fad5cb5
Add try/catch/finally blocks around commit phase passes
acdlite Nov 28, 2016
ece9f7b
NoopBoundary -> RethrowBoundary
acdlite Nov 28, 2016
226ee8f
Only throw uncaught error once there is no more work to perform
acdlite Nov 29, 2016
7386e82
Add more tests for incremental error handling
gaearon Nov 5, 2016
d27cada
Verify batched updates get scheduled despite errors
gaearon Nov 5, 2016
cc60f25
Remove outdated comment
gaearon Nov 30, 2016
778183e
Record tests
gaearon Nov 30, 2016
54978e9
Always reset nextUnitOfWork on error
gaearon Nov 30, 2016
c1f2eb2
Add a passing test for unmounting behavior on crashed tree
gaearon Nov 30, 2016
46581a3
Top-level errors
acdlite Nov 30, 2016
b32c86e
Remove outdated comment
gaearon Nov 30, 2016
7bc10c0
Separate Rethrow and Noop scenarios in boundary tests
gaearon Nov 30, 2016
cf20dfa
Move try block outside the commit loops
acdlite Nov 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove outdated comment 
It was fixed in #8451.
  • Loading branch information
@gaearon
gaearon committed Nov 30, 2016
commit cc60f25bc2ab743a93c72c6bd454d9ad3b2b356c
3 changes: 0 additions & 3 deletions src/renderers/dom/__tests__/ReactDOMProduction-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,6 @@ describe('ReactDOMProduction', () => {
expect(function() {
class Component extends React.Component {
render() {
// FIXME: undefined is a valid return type in Fiber, at least in the
// current implementation. It's treated as empty. I don't know why we
// sometimes get false positives.
return undefined;
}
}
Expand Down