Remove viewport metrics, other pageX/pageY behaviors #9290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Seems like it's indeed IE8 only.
|
gaearon
requested changes
Mar 30, 2017
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Please run npm run prettier so that CI passes
nhunzaker
force-pushed
the
remove-viewport-metrics
branch
from
211f861 to
b48cfa3
Compare
Contributor
Author
|
@gaearon Prettiered and squashed. |
nhunzaker
force-pushed
the
remove-viewport-metrics
branch
from
b48cfa3 to
2769563
Compare
Contributor
Author
|
Should pass, waiting on a lint fix: #9300 |
Collaborator
|
It will also fail because you need to run |
event.pageX and event.pageY are in every browser React supports.
nhunzaker
force-pushed
the
remove-viewport-metrics
branch
from
2769563 to
c272e49
Compare
Contributor
Author
|
Done. I am sorry for the trouble. |
gaearon
approved these changes
Mar 31, 2017
Collaborator
|
No worries, thank you for this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pageXandpageYare supported in every browser, which makes it possible to remove a lot of code. I don't expect this one to get merged so easily; I'm happy to provide any additional testing.Test methodology
I created a case here using React's pageX/pageY feature test:
http://codepen.io/nhunzaker/pen/GWwmyK
Test Results
YES
IE9
FF 3
Chrome 15
Opera 10.6
Yandex 14.12
Safari 4 - Windows
Safari 4 - Mac
Windows Phone 8.1
iOS 4.3.2
Android 4 (Native Browser)
Android 4.4 (Chrome)
NO
IE8