Skip to content

Reimplement React.Children #9339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koba04 wants to merge 21 commits into from
Closed

Reimplement React.Children #9339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
da48ae0
Remove to use PooledClass for traverseAllChildren
koba04 Apr 5, 2017
efb7107
move traverseAllChildren into ReactChildren
koba04 Apr 12, 2017
d5b4b57
Use mapChildren to forEach and toArray
koba04 Apr 14, 2017
437120d
Remove React.Children.mapIntoWithKeyPrefixInternal
koba04 Apr 17, 2017
a2bcddc
Run prettier
koba04 Apr 17, 2017
e6060f6
Remove unnecessary arguments
koba04 Apr 17, 2017
ed041b4
Remove an unused argument from ReactChildren.count
koba04 Apr 18, 2017
1ead882
Test for a single child and an array with one item
koba04 Apr 20, 2017
ab49e3a
Add component stack to invalid-object-child error (cherry-pick #9415)
koba04 Apr 21, 2017
2e982b9
Add test for single child witout key
koba04 Apr 21, 2017
892dd52
Improve component type check in getComponentKey (cherry-pick #9464)
koba04 Apr 26, 2017
1e5ab7c
Add Flow types
koba04 May 8, 2017
a6cdc05
Type for getReactElementKey
koba04 May 8, 2017
8a30669
Remove comments for types
koba04 May 8, 2017
8879aef
Run prettier
koba04 May 8, 2017
d57fab8
Do not allocate results with forEach
koba04 May 9, 2017
4ceb58f
Remove unnecessary traverseContext
koba04 May 9, 2017
87aefbf
Record fiber tests
koba04 May 9, 2017
d920c9b
Rebase #9903
koba04 Jun 12, 2017
96b675c
Fix flow errors with some $FlowFixMe
koba04 Jun 15, 2017
61981da
Fix $FlowFixMe
koba04 Jun 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test for a single child and an array with one item
  • Loading branch information
@koba04
koba04 committed Jun 29, 2017
commit 1ead8825f68bd7404e7426affc2942f7fadb6d1a
5 changes: 0 additions & 5 deletions src/isomorphic/children/ReactChildren.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ var SUBSEPARATOR = ':';
*
*/

/**
* TODO: Test that a single child and an array with one item have the same key
* pattern.
*/

var didWarnAboutMaps = false;

/**
Expand Down
4 changes: 2 additions & 2 deletions src/isomorphic/children/__tests__/ReactChildren-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ describe('ReactChildren', () => {
return kid;
});

var simpleKid = <span />;
var simpleKid = <span key="simple" />;
var instance = <div>{simpleKid}</div>;
React.Children.forEach(instance.props.children, callback, context);
expect(callback).toHaveBeenCalledWith(simpleKid, 0);
Expand All @@ -71,7 +71,7 @@ describe('ReactChildren', () => {
context,
);
expect(callback).toHaveBeenCalledWith(simpleKid, 0);
expect(mappedChildren[0]).toEqual(<span key=".0" />);
expect(mappedChildren[0]).toEqual(<span key=".$simple" />);
});

it('should treat single child in array as expected', () => {
Expand Down