Replacing <img> to Gatsby Images #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
<img>tags to<GatsbyImage>only for local images,I had to refactor photos folder to be used by graphql.
It seems that Gatsby Images are not made use paths as it has been done on this project, so if we want to use Gatsby Images for dynamic components like
person.jswe should use local images, or keep using<img>tags.I also think that there are some deprecated packages that disturb
gatsby-plugin-imagewhen loading the index first imageOne last thing, Gatsby Images do not handle
.svgfiles, maybe we should switch logo file to png, or decide to finally not usegatsby-plugin-image