Skip to content

Conversation

@aberres
Copy link
Contributor

@aberres aberres commented Feb 22, 2021

As saleElapsed is now floating point the variable is no more missdetected as categorical. Hence the workaround to fix the classification must be removed.

With these changes the notebook runs once again without throwing errors.

@jph00

saleElaped is now detected as continuous variable right away.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00
Copy link
Member

jph00 commented Feb 22, 2021

Many thanks!

@jph00 jph00 merged commit 8be5807 into fastai:master Feb 22, 2021
georghoeller pushed a commit to georghoeller/fastbook that referenced this pull request Mar 3, 2024
saleElaped is now detected as continuous variable right away.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants