nodenext compatibility #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antiavanti
reviewed
Aug 11, 2025
|
|
||
| declare namespace fastifyHttpProxy { | ||
| export interface FastifyHttpProxyOptions extends FastifyReplyFromOptions { | ||
| upstream: string; |
There was a problem hiding this comment.
If #15 (simple fromOpts.base = opts.upstream), why only upstream: string;?
https://github.com/fastify/fastify-reply-from/blob/main/types/index.d.ts#L109
base?: string | string[];
([] used to instrument undici.BalancedPool) -> https://github.com/fastify/fastify-reply-from?tab=readme-ov-file#base
There was a problem hiding this comment.
Open a new issue to discuss this or provide a PR to fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct