Remove unneeded Symbol.species code

[feross]

We now handle calls like:

new Buffer(arraybuffer, 2, 8) so there's no need for this workaround originally implemented in: #97

More info: https://bugs.chromium.org/p/v8/issues/detail?id=4665#c4

Fixes #260. Supersedes #261

[mikeal]

Test still fails for me.

Here’s a super minimal test you can run yourself.

const { Buffer } = require('buffer')
const assert = require('assert')
it('subarray', done => {
  const test = Buffer.from('asdf')
  const sub = test.subarray(2,3)
  assert.ok(Buffer.isBuffer(sub))
  done()
})

This will fail:

npx polendina —cleanup test.js

[mikeal]

You know what, I take it back, this does fix it, the module just isn’t being picked up properly when I use a git remote branch in the package.json. If I change the import to a relative path where I’ve checked out this branch the test passes.

👍

[feross]

Released as 5.6.0