Skip to content

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Sep 18, 2023

Also be more explicit with CAR storage options.

Depends on:

The graphsync one being the most tricky to get over the line and released. If it ends up being too much hassle I'll comment out the test here so it passes and work on that separately.

@rvagg rvagg force-pushed the rvagg/identity-cids branch from 50beaf5 to 8b5010f Compare September 18, 2023 11:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #426 (1535a73) into main (1c31d7c) will decrease coverage by 0.34%.
The diff coverage is 45.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   76.42%   76.09%   -0.34%     
==========================================
  Files          85       84       -1     
  Lines        6287     6320      +33     
==========================================
+ Hits         4805     4809       +4     
- Misses       1237     1256      +19     
- Partials      245      255      +10     
Files Changed Coverage Δ
cmd/lassie/fetch.go 30.97% <0.00%> (-0.87%) ⬇️
pkg/internal/testutil/gen.go 62.69% <ø> (-1.43%) ⬇️
pkg/storage/deferredstoragecar.go 59.32% <38.23%> (-12.45%) ⬇️
pkg/internal/itest/testpeer/peerhttpserver.go 67.88% <50.00%> (-1.06%) ⬇️
pkg/internal/itest/testpeer/generator.go 75.00% <100.00%> (ø)
pkg/storage/cachingtempstore.go 74.69% <100.00%> (+0.15%) ⬆️
pkg/storage/duplicateaddercar.go 92.50% <100.00%> (+0.39%) ⬆️

... and 5 files with indirect coverage changes

also be more explicit with CAR storage options
@rvagg rvagg marked this pull request as ready for review September 19, 2023 10:24
@rvagg rvagg force-pushed the rvagg/identity-cids branch from 9446e98 to 1535a73 Compare September 19, 2023 10:24
@rvagg rvagg merged commit 70fc1d1 into main Sep 19, 2023
@rvagg rvagg deleted the rvagg/identity-cids branch September 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants