Skip to content

fix(fcm): Exporting all types of Messages so they can be used by consumers #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 4, 2021
Merged

fix(fcm): Exporting all types of Messages so they can be used by consumers #1147

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6336e3
feat: Exporting all types of Messages so they can be used by consumers
BorntraegerMarc Jan 28, 2021
6a69e71
feat(exportMessageTypes): Testing TokenMessage
BorntraegerMarc Feb 3, 2021
8755878
feat(exportMessageTypes): Added tests for all Message types
BorntraegerMarc Feb 3, 2021
b471877
feat(exportMessageTypes): Fixed build
BorntraegerMarc Feb 3, 2021
5f4b793
Merge branch 'master' into patch-1
BorntraegerMarc Feb 4, 2021
df80c59
feat(exportMessageTypes): Better unit tests
BorntraegerMarc Feb 4, 2021
dce2e00
feat(exportMessageTypes): Deleted unneeded separate TS test
BorntraegerMarc Feb 4, 2021
fca55b7
feat(exportMessageTypes): Fixed build
BorntraegerMarc Feb 4, 2021
e99eee0
feat(exportMessageTypes): Fixed linting
BorntraegerMarc Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(exportMessageTypes): Fixed build
  • Loading branch information
@BorntraegerMarc
BorntraegerMarc authored Feb 4, 2021
commit fca55b7ff5ac5c0d666a7d53fbd8e14384a200d9
3 changes: 3 additions & 0 deletions test/unit/messaging/messaging.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ const expect = chai.expect;

import Message = messaging.Message;
import TokenMessage = messaging.TokenMessage;
import TopicMessage = messaging.TopicMessage;
import ConditionMessage = messaging.ConditionMessage;
import MessagingOptions = messaging.MessagingOptions;
import MessagingPayload = messaging.MessagingPayload;
import MessagingDevicesResponse = messaging.MessagingDevicesResponse;
Expand Down Expand Up @@ -825,6 +827,7 @@ describe('Messaging', () => {
).should.eventually.be.rejected.and.have.property('code', 'app/invalid-credential');
});

// This test was added to also verify https://github.com/firebase/firebase-admin-node/issues/1146
it('should be fulfilled when called with different message types', () => {
const messageIds = [
'projects/projec_id/messages/1',
Expand Down