Skip to content

chore: Clean up nightly workflow trigger tests #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2021
Merged

chore: Clean up nightly workflow trigger tests #1212

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee5b5cf
chore: Clean up nightly workflow trigger tests
lahirumaramba Mar 31, 2021
4241c81
Merge branch 'master' into lm-remove-email-itest
lahirumaramba Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: Clean up nightly workflow trigger tests 
- Remove failing integration test added to trigger the send email workflow in nightly builds.
  • Loading branch information
@lahirumaramba
lahirumaramba authored Mar 31, 2021
commit ee5b5cfbf8ae0b832ad8e52a3b6b11050e9591c7
6 changes: 0 additions & 6 deletions test/integration/remote-config.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,6 @@ describe('admin.remoteConfig', () => {
}).to.throw('Cannot set property etag of #<RemoteConfigTemplateImpl> which has only a getter');
});

// A failing integration test to trigger the send email action.
// Remove this once the testing is complete.
it('A failing integration test to trigger nightly email notifications', () => {
expect('a').to.be.equal('b');
});

describe('validateTemplate', () => {
it('should succeed with a vaild template', () => {
// set parameters, groups, and conditions
Expand Down