Skip to content

fix(auth): Better type hierarchies for Auth API #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2021
Merged

fix(auth): Better type hierarchies for Auth API #1294

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d09b82
fix(auth): Better type heirarchies for Auth API
hiranya911 May 24, 2021
19b2c0e
fix: Moved factorId back to the base types
hiranya911 May 25, 2021
5e9e6bf
Merged with main
hiranya911 May 25, 2021
76b1e3e
fix: Updated API report
hiranya911 May 26, 2021
0330791
fix: Fixed a grammar error in comment
hiranya911 May 26, 2021
2f1d21c
fix: Update to comment text
hiranya911 May 27, 2021
6496051
Merge branch 'master' into hkj-better-types
hiranya911 May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merged with main
  • Loading branch information
@hiranya911
hiranya911 committed May 25, 2021
commit 5e9e6bfde4f47313d7ae3aa8ca912145b43690f5
4 changes: 0 additions & 4 deletions etc/firebase-admin.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,17 +251,13 @@ export namespace auth {
}
export interface OIDCAuthProviderConfig extends BaseAuthProviderConfig {
clientId: string;
clientSecret?: string;
issuer: string;
responseType?: OAuthResponseType;
}
export interface OIDCUpdateAuthProviderRequest {
clientId?: string;
clientSecret?: string;
displayName?: string;
enabled?: boolean;
issuer?: string;
responseType?: OAuthResponseType;
}
export interface PhoneIdentifier {
// (undocumented)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.