Skip to content

Update SignOptions to fix a type error #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update SignOptions to fix a type error #1436

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b40284
Update SignOptions to fix a type error
lahirumaramba Sep 22, 2021
df44aed
Update package json
lahirumaramba Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update package json
  • Loading branch information
@lahirumaramba
lahirumaramba committed Sep 22, 2021
commit df44aed3b6906154d128993976cf5946333053c8
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"@types/chai": "^4.0.0",
"@types/chai-as-promised": "^7.1.0",
"@types/firebase-token-generator": "^2.0.28",
"@types/jsonwebtoken": "^8.5.0",
"@types/jsonwebtoken": "^8.5.5",
Copy link
Contributor

@hiranya911 hiranya911 Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should just downgrade and pin this dependency to v8.5.1. Implementing all these workarounds to deal with a badly versioned dependency doesn't sound very good to me. WDYT?

Copy link
Member Author

@lahirumaramba lahirumaramba Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Created a new PR to pin the dependency. I will close this for now.

"@types/lodash": "^4.14.104",
"@types/minimist": "^1.2.0",
"@types/mocha": "^8.2.2",
Expand Down