Skip to content

Support updating custom claims in updateUser() #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+184 −5
Open

Support updating custom claims in updateUser() #1882

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
59d329b
Add customUserClaims to UpdateRequest
brettwillis Aug 22, 2022
a8f3945
Test coverage for updating custom claims
brettwillis Aug 22, 2022
c132b6b
Merge branch 'master' into customclaims-in-updateuser
brettwillis Mar 8, 2023
dc1055d
Fix tests and lint
brettwillis Mar 8, 2023
aaf3a2f
Add integration tests
brettwillis Mar 8, 2023
9fa0484
Remove unsupported properties from CreateRequest
brettwillis Feb 7, 2024
53260f7
Merge branch 'master' into customclaims-in-updateuser
brettwillis Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unsupported properties from CreateRequest
  • Loading branch information
@brettwillis
brettwillis committed Feb 7, 2024
commit 9fa048445bd6e10753abda5fa598abac6c67d79f
13 changes: 9 additions & 4 deletions src/auth/auth-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,9 @@ export interface MultiFactorUpdateSettings {
}

/**
* Interface representing the properties to update on the provided user.
* Interface representing the base properties for `CreateRequest` and `UpdateRequest`.
*/
export interface UpdateRequest {

export interface BaseCreateUpdateUserRequest {
/**
* Whether or not the user is disabled: `true` for disabled;
* `false` for enabled.
Expand Down Expand Up @@ -163,6 +162,12 @@ export interface UpdateRequest {
* The user's photo URL.
*/
photoURL?: string | null;
}

/**
* Interface representing the properties to update on the provided user.
*/
export interface UpdateRequest extends BaseCreateUpdateUserRequest {

/**
* The user's updated multi-factor related properties.
Expand Down Expand Up @@ -238,7 +243,7 @@ export interface UserProvider {
* Interface representing the properties to set on a new user record to be
* created.
*/
export interface CreateRequest extends UpdateRequest {
export interface CreateRequest extends BaseCreateUpdateUserRequest {

/**
* The user's `uid`.
Expand Down