Skip to content

updated error messaging for auth-api-request.getAccountInfoByFederatedUid() #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

updated error messaging for auth-api-request.getAccountInfoByFederatedUid() #2305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
updated error messaging for auth-api-request.getAccountInfoByFederate… 
…dUid()

The previous error handling for the getAccountInfoByFederatedUid() method was misleading. In scenarios where the providerId was valid, but the uid was missing or invalid, the system would still return a "invalid-provider-id" error code. Now, the appropriate error code will be returned depending on which validation is failing.
  • Loading branch information
Remzi Zayid committed Sep 15, 2023
commit b070c702565964d17b93397daf4054bd6af8e991
4 changes: 3 additions & 1 deletion src/auth/auth-api-request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,8 +1152,10 @@ export abstract class AbstractAuthRequestHandler {
}

public getAccountInfoByFederatedUid(providerId: string, rawId: string): Promise<object> {
if (!validator.isNonEmptyString(providerId) || !validator.isNonEmptyString(rawId)) {
if (!validator.isNonEmptyString(providerId)) {
throw new FirebaseAuthError(AuthClientErrorCode.INVALID_PROVIDER_ID);
} else if (!validator.isNonEmptyString(rawId)) {
throw new FirebaseAuthError(AuthClientErrorCode.INVALID_UID);
}

const request = {
Expand Down