Skip to content

adding integration tests #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: passkeys
Choose a base branch
from
Open

adding integration tests #2340

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad014e7
adding integration tests
pragatimodi Oct 18, 2023
95f958e
integration tests activated
pragatimodi Mar 20, 2024
f14850a
remove `update`
pragatimodi Mar 20, 2024
0931ca9
lint fixes
pragatimodi Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
integration tests activated
  • Loading branch information
@pragatimodi
pragatimodi committed Mar 20, 2024
commit 95f958e75a6e1d31405d8857d6649a0862820c4f
83 changes: 41 additions & 42 deletions test/integration/auth.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import firebase from '@firebase/app-compat';
import '@firebase/auth-compat';
import { clone } from 'lodash';
import { clone, update } from 'lodash';
import { User, FirebaseAuth } from '@firebase/auth-types';
import {
generateRandomString, projectId, apiKey, noServiceAccountApp, cmdArgs,
Expand Down Expand Up @@ -1222,7 +1222,7 @@ describe('admin.auth', () => {
minLength: 6,
}
}
})
})
});

const mfaSmsEnabledTotpEnabledConfig: MultiFactorConfig = {
Expand Down Expand Up @@ -1758,45 +1758,44 @@ describe('admin.auth', () => {
});
});

describe('Passkey config management operations', () => {

// Before each test, reset the passkey config to the initial state
beforeEach(async () => {
// const resetRequest = { expectedOrigins: expectedPasskeyConfig.expectedOrigins };
// await getAuth().passkeyConfigManager().updatePasskeyConfig(resetRequest);
});

it('createPasskeyConfig() should create passkey config with expected passkeyConfig', async () => {
const rpId = projectId + '.firebaseapp.com';
const createRequest = { expectedOrigins: ['app1', 'example.com'] };
const createdPasskeyConfig = await getAuth().passkeyConfigManager().createPasskeyConfig(rpId, createRequest);

expect(createdPasskeyConfig.name).to.deep.equal('projects/' + projectId + '/passkeyConfig');
expect(createdPasskeyConfig.rpId).to.deep.equal(projectId + '.firebaseapp.com');
expect(createdPasskeyConfig.expectedOrigins).to.deep.equal(['app1', 'example.com']);
});

// TODO: uncomment when the GET endpoint is released in prod
// it('getPasskeyConfig() should resolve with expected passkeyConfig', async () => {
// const actualPasskeyConfig = await getAuth().passkeyConfigManager().getPasskeyConfig();

// expect(actualPasskeyConfig.name).to.deep.equal('projects/' + projectId + '/passkeyConfig');
// expect(actualPasskeyConfig.rpId).to.deep.equal(projectId + '.firebaseapp.com');
// expect(actualPasskeyConfig.expectedOrigins).to.deep.equal(['app1', 'example.com']);
// });

it('updatePasskeyConfig() should resolve with updated expectedOrigins', async () => {
const updateRequest = {
expectedOrigins: ['app1', 'example.com', 'app2']
};

const updatedPasskeyConfig = await getAuth().passkeyConfigManager().updatePasskeyConfig(updateRequest);

expect(updatedPasskeyConfig.name).to.deep.equal('projects/' + projectId + '/passkeyConfig');
// TODO: backend validation needs to fixed in order for this statement to succeed.
// expect(updatedPasskeyConfig.rpId).to.deep.equal(projectId + '.firebaseapp.com');
expect(updatedPasskeyConfig.expectedOrigins).to.deep.equal(['app1', 'example.com', 'app2']);
});
describe('Passkey config management operations', () => {

// Define expected passkey configuration
const expectedPasskeyConfig = {
name: `projects/{$projectId}/passkeyConfig`,
rpId: `{$projectId}.firebaseapp.com`,
expectedOrigins: ['app1', 'example.com'],
};

it('createPasskeyConfig() should create passkey config with expected passkeyConfig', async () => {
const rpId = projectId + '.firebaseapp.com';
const createRequest = { expectedOrigins: ['app1', 'example.com'] };
const createdPasskeyConfig = await getAuth().passkeyConfigManager().createPasskeyConfig(rpId, createRequest);

expect(createdPasskeyConfig.name).to.deep.equal(expectedPasskeyConfig.name);
expect(createdPasskeyConfig.rpId).to.deep.equal(expectedPasskeyConfig.rpId);
expect(createdPasskeyConfig.expectedOrigins).to.deep.equal(expectedPasskeyConfig.expectedOrigins);
});

it('getPasskeyConfig() should resolve with expected passkeyConfig', async () => {
const actualPasskeyConfig = await getAuth().passkeyConfigManager().getPasskeyConfig();

expect(actualPasskeyConfig.name).to.deep.equal(expectedPasskeyConfig.name);
expect(actualPasskeyConfig.rpId).to.deep.equal(expectedPasskeyConfig.rpId);
expect(actualPasskeyConfig.expectedOrigins).to.deep.equal(expectedPasskeyConfig.rpId);
});

it('updatePasskeyConfig() should resolve with updated expectedOrigins', async () => {
const updateRequest = {
expectedOrigins: ['app1', 'example.com', 'app2']
};

const updatedPasskeyConfig = await getAuth().passkeyConfigManager().updatePasskeyConfig(updateRequest);

expect(updatedPasskeyConfig.name).to.deep.equal(expectedPasskeyConfig.name);
expect(updatedPasskeyConfig.rpId).to.deep.equal(expectedPasskeyConfig.rpId);
expect(updatedPasskeyConfig.expectedOrigins).to.deep.equal(updateRequest.expectedOrigins);
});
});

// Sanity check OIDC/SAML config management API.
Expand Down Expand Up @@ -2063,7 +2062,7 @@ describe('admin.auth', () => {
}
return getAuth().tenantManager().updateTenant(createdTenantId, updateRequestNoMfaConfig)
});

it('updateTenant() should not update tenant reCAPTCHA config is undefined', () => {
expectedUpdatedTenant.tenantId = createdTenantId;
const updatedOptions2: UpdateTenantRequest = {
Expand Down