Skip to content

Add public SSRC methods #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 5, 2024
Merged

Add public SSRC methods #2458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a01fe56
[SSRC] Add API changes needed for SSRC
trekforever Feb 13, 2024
e48a65a
Strip whitespace and improve documentation consistency
erikeldridge Feb 13, 2024
ab077c4
[SSRC] Add client internals and tests
trekforever Feb 13, 2024
8f145c6
Update URL to match API proposal
erikeldridge Feb 13, 2024
afec9ec
[SSRC] Add changes to RC
trekforever Feb 13, 2024
1bfb4b2
Remove unused field, and rename another for consistency
erikeldridge Feb 13, 2024
ca8093a
Export types from index file
erikeldridge Feb 14, 2024
8c883bc
Add RemoteConfigServerTemplateOptions type and update extracted API
erikeldridge Feb 14, 2024
0cb0153
Apply suggestions from code review
erikeldridge Feb 15, 2024
72fa815
Remove getServerTemplate integration test
erikeldridge Feb 15, 2024
9a9a49e
Use console.log, for consistency
erikeldridge Feb 20, 2024
df03bd8
Merge branch 'ssrc' into ssrc-rc
erikeldridge Feb 20, 2024
e6e5779
Apply suggestions from code review
erikeldridge Feb 20, 2024
3da3f28
Incorporate review feedback
erikeldridge Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update URL to match API proposal
  • Loading branch information
@erikeldridge
erikeldridge committed Feb 13, 2024
commit 8f145c672575aaea3cf057086ad06147144bf113
2 changes: 1 addition & 1 deletion src/remote-config/remote-config-api-client-internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export class RemoteConfigApiClient {
.then((url) => {
const request: HttpRequestConfig = {
method: 'GET',
url: `${url}/templates/server`,
url: `${url}/namespaces/firebase-server/serverRemoteConfig`,
headers: FIREBASE_REMOTE_CONFIG_HEADERS
};
return this.httpClient.send(request);
Expand Down
4 changes: 2 additions & 2 deletions test/unit/remote-config/remote-config-api-client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ describe('RemoteConfigApiClient', () => {
.should.eventually.be.rejectedWith(noProjectId);
});

// // tests for api response validations
// tests for api response validations
runEtagHeaderTests(() => apiClient.getServerTemplate());
runErrorResponseTests(() => apiClient.getServerTemplate());

Expand All @@ -685,7 +685,7 @@ describe('RemoteConfigApiClient', () => {
expect(resp.version).to.deep.equal(TEST_RESPONSE.version);
expect(stub).to.have.been.calledOnce.and.calledWith({
method: 'GET',
url: 'https://firebaseremoteconfig.googleapis.com/v1/projects/test-project/templates/server',
url: 'https://firebaseremoteconfig.googleapis.com/v1/projects/test-project/namespaces/firebase-server/serverRemoteConfig',
headers: EXPECTED_HEADERS,
});
});
Expand Down