Skip to content

fix: issue 2467: add async to send each loop to prevent local validation #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix: issue 2467: add async to send each loop to prevent local validation #2469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac78807
issue 2467: add async to send each loop to prevent local validation f…
DyosTheNerd Feb 24, 2024
eb409c5
Merge branch 'master' into issue/2467-local-validation
lahirumaramba Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
issue 2467: add async to send each loop to prevent local validation f… 
…rom throwing in an unknown state
  • Loading branch information
@DyosTheNerd
DyosTheNerd committed Feb 24, 2024
commit ac78807ccc7c64c5cf2520d650f75df5a3693f2c
2 changes: 1 addition & 1 deletion src/messaging/messaging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ export class Messaging {

return this.getUrlPath()
.then((urlPath) => {
const requests: Promise<SendResponse>[] = copy.map((message) => {
const requests: Promise<SendResponse>[] = copy.map(async (message) => {
validateMessage(message);
const request: { message: Message; validate_only?: boolean } = { message };
if (dryRun) {
Expand Down
13 changes: 13 additions & 0 deletions test/unit/messaging/messaging.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,19 @@ describe('Messaging', () => {
.should.eventually.be.rejectedWith('Exactly one of topic, token or condition is required');
});

it('should reject a message when it does not pass local validation, but still try the other messages', () => {
const invalidMessage: Message = { token: 'a', notification: { imageUrl: 'abc' } };
const messageIds = [
'projects/projec_id/messages/1',
];
messageIds.forEach(id => mockedRequests.push(mockSendRequest(id)))
return messaging.sendEach([invalidMessage, validMessage])
.then((response: BatchResponse) => {
expect(response.successCount).to.equal(1);
expect(response.failureCount).to.equal(1);
});
});

const invalidDryRun = [null, NaN, 0, 1, '', 'a', [], [1, 'a'], {}, { a: 1 }, _.noop];
invalidDryRun.forEach((dryRun) => {
it(`should throw given invalid dryRun parameter: ${JSON.stringify(dryRun)}`, () => {
Expand Down