Skip to content

Add functionality to accept a JSON template string when initializing a RC server template #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Add functionality to accept a JSON template string when initializing a RC server template #2520

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
43e0f2e
Add support to pass in a json string for RC server template initializ…
trekforever Apr 2, 2024
dac5893
Add support to pass in a json string for RC server template initializ…
trekforever Apr 2, 2024
de597ee
Merge ssrc changes
trekforever Apr 2, 2024
0608aaf
Apply lint changes
trekforever Apr 2, 2024
e926fcd
Update comments
trekforever Apr 2, 2024
48fe8a2
Run api-extractor:local
trekforever Apr 2, 2024
295636b
Update comments and address feedback
trekforever Apr 3, 2024
9ae7d96
Update inline comment and lint fixes
trekforever Apr 3, 2024
c7d4c6c
Revert toJSON functionality for ServerTemplate
trekforever Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comments
  • Loading branch information
@trekforever
trekforever committed Apr 2, 2024
commit e926fcd56bf9c2ed70af9881e07a5207096d5d72
3 changes: 1 addition & 2 deletions src/remote-config/remote-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export class RemoteConfig {
const template = new ServerTemplateImpl(
this.client, new ConditionEvaluator(), options?.defaultConfig);
if (options?.template) {
// Check and instantiates via json string
// Check and instantiates the template via a json string
if (isString(options?.template)) {
try {
template.cache = new ServerTemplateDataImpl(JSON.parse(options?.template));
Expand All @@ -210,7 +210,6 @@ export class RemoteConfig {
);
}
} else {
// check and instantiates via ServerTemplateData
template.cache = options?.template;
}
}
Expand Down