Skip to content

Add #set and #toJSON to RC ServerTemplate #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Add #set and #toJSON to RC ServerTemplate #2522

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b171d2b
Add #set on ServerTemplate to allow for setting and caching a server …
trekforever Apr 5, 2024
f427727
Simplify initServerTemplate to make use of the new setter
trekforever Apr 5, 2024
3d8d3d4
Update tests
trekforever Apr 5, 2024
18f5630
Address comments and feedback
trekforever Apr 5, 2024
44101ea
Update API docs
trekforever Apr 5, 2024
05ba48c
Add export for new type ServerTemplateDataType to index.ts
trekforever Apr 5, 2024
9bbe9e3
Update some inline comments
trekforever Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests
  • Loading branch information
@trekforever
trekforever committed Apr 5, 2024
commit 3d8d3d4e0adf1de181bc34d489b874d5d93b128a
4 changes: 2 additions & 2 deletions test/unit/remote-config/remote-config.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ describe('RemoteConfig', () => {
const cond = c as NamedCondition;
expect(cond.name).to.equal('ios');

const parsed = JSON.parse(JSON.stringify(template.toJSON()));
const parsed = template.toJSON();
const expectedTemplate = deepCopy(SERVER_REMOTE_CONFIG_RESPONSE);
const expectedVersion = deepCopy(VERSION_INFO);
expectedVersion.updateTime = new Date(expectedVersion.updateTime).toUTCString();
Expand Down Expand Up @@ -866,7 +866,7 @@ describe('RemoteConfig', () => {
}
});

const parsed = JSON.parse(JSON.stringify(template.toJSON()));
const parsed = template.toJSON();
const expectedTemplate = deepCopy(SERVER_REMOTE_CONFIG_RESPONSE);
const expectedVersion = deepCopy(VERSION_INFO);
expectedVersion.updateTime = new Date(expectedVersion.updateTime).toUTCString();
Expand Down