Skip to content

feat(fcm): Add HTTP2 support for sendEach() and sendEachForMulticast() #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 23, 2024
Merged

feat(fcm): Add HTTP2 support for sendEach() and sendEachForMulticast() #2550

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a3e45da
Refactor `api-requets` to prepare to handle both HTTP/1.1 and HTTP/2 …
jonathanedey Apr 30, 2024
ad9d780
Added HTTP2 support for `sendEach()` and sendEachForMulticast` with i…
jonathanedey May 9, 2024
991f069
fix: lint
jonathanedey May 9, 2024
9100a52
Added unit tests
jonathanedey May 10, 2024
1427e7f
Added tests for `Http2Client` and `AuthorizedHttp2Client`
jonathanedey May 16, 2024
2003f30
Address api review changes and typos.
jonathanedey Jun 12, 2024
8b2a881
Merge branch 'master' into je-fcm-http2
jonathanedey Jun 13, 2024
564383a
TW changes, backticks and typos
jonathanedey Jul 17, 2024
2226a3e
fix deprecation note
jonathanedey Jul 17, 2024
254589c
Reword deprecation note.
jonathanedey Jul 23, 2024
7ae328b
Merge branch 'master' into je-fcm-http2
jonathanedey Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reword deprecation note.
  • Loading branch information
@jonathanedey
jonathanedey committed Jul 23, 2024
commit 254589c1a3964bbe880d545b6a8ef310eda5282d
2 changes: 1 addition & 1 deletion src/messaging/messaging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ export class Messaging {
* messaging.sendEach(messages);
* ```
*
* @deprecated This is to be removed once the HTTP/2 transport implementation reaches the same
* @deprecated This will be removed when the HTTP/2 transport implementation reaches the same
* stability as the legacy HTTP/1.1 implementation.
*/
Copy link
Member

@lahirumaramba lahirumaramba Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a TW review on this?

public enableLegacyHttpTransport(): void {
Expand Down