Skip to content

change: Deprecate Node.js 16 support #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2024
Merged

change: Deprecate Node.js 16 support #2574

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b67efc1
change: Deprecate Node versions that reached EoL
lahirumaramba May 27, 2024
d35b690
change expected error to regex
lahirumaramba May 28, 2024
569193e
update readme.md
lahirumaramba May 28, 2024
feb555a
update readme.md
lahirumaramba May 28, 2024
d2636d7
Merge branch 'master' into lm-node-update
lahirumaramba May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change expected error to regex
  • Loading branch information
@lahirumaramba
lahirumaramba committed May 28, 2024
commit d35b6909618aad7994f119b617c88da3364d5912
2 changes: 1 addition & 1 deletion test/unit/app/firebase-app.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ describe('FirebaseApp', () => {
process.env[FIREBASE_CONFIG_VAR] = '{,,';
expect(() => {
firebaseNamespace.initializeApp();
}).to.throw('Failed to parse app options file: SyntaxError: Unexpected token ,');
}).to.throw(/Failed to parse app options file: SyntaxError:/);
});

it('should throw when the environment variable points to an empty file', () => {
Expand Down