feat(rc): SSRC targeting #2665
Merged
feat(rc): SSRC targeting #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2628) initial skeleton for custom signal evaluation logic --------- Co-authored-by: Kevin Elko <[email protected]>
* initial skeleton for custom signal evaluation logic * adjust some formatting * remove extra curly brace * run lint * Run apidocs * Split EvaluationContext into UserProvidedSignals and PredefinedSignals * rerun apidocs * add logic for remaining custom signal operators * more test cases * test cases for numeric operators * update tests to be way more robust and implement handling for a few edge cases * update some comments --------- Co-authored-by: Kevin Elko <[email protected]>
* refactor numeric version parsing logic and add more test cases * run lint * test cases for max num segments * run lint on tests --------- Co-authored-by: Kevin Elko <[email protected]>
lahirumaramba
requested changes
Aug 20, 2024
jenh
requested changes
Aug 22, 2024
jenh
approved these changes
Aug 26, 2024
Contributor
jenh
left a comment
jenh
left a comment
There was a problem hiding this comment.
Looks good to me with the Eg to (e.g., ...) nit. :D
lahirumaramba
approved these changes
Sep 5, 2024
Merged
This was referenced Oct 4, 2024
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom targeting evaluation logic
RELEASE NOTE: Added support for server-side custom signals targeting.