Skip to content

feat: Add contentChanged in ApnsPayload #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: Add contentChanged in ApnsPayload #2934

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
126cbc4
Add contentChanged in ApnsPayload interface
woals4815 Jun 15, 2025
f589667
Add validating contentChanged logic
woals4815 Jun 15, 2025
31c70cf
Add contentChanged in MessagingOptions
woals4815 Jun 15, 2025
bce9031
Add unit test case for contentChanged property
woals4815 Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add validating contentChanged logic
  • Loading branch information
@woals4815
woals4815 committed Jun 15, 2025
commit f5896671dd6fb2d7f78b090445c83c801d97317f
10 changes: 10 additions & 0 deletions src/messaging/messaging-internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ function validateAps(aps: Aps): void {
contentAvailable: 'content-available',
mutableContent: 'mutable-content',
threadId: 'thread-id',
contentChanged: 'content-changed',
};
Object.keys(propertyMappings).forEach((key) => {
if (key in aps && propertyMappings[key] in aps) {
Expand All @@ -300,6 +301,15 @@ function validateAps(aps: Aps): void {
delete aps['mutable-content'];
}
}

const contentChanged = aps['content-changed'];
if (typeof contentChanged !== 'undefined' && contentChanged !== 1) {
if (contentChanged === true) {
aps['content-changed'] = 1;
} else {
delete aps['content-changed'];
}
}
}

function validateApsSound(sound: string | CriticalSound | undefined): void {
Expand Down