Skip to content

Core admin init #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Core admin init #2953

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0fcd4b0
Implemented initilization and queries for the admin node core sdk, ch…
Jul 16, 2025
f1ddd5c
Draft: Implemented the initialization API and 'querRef' function; ref…
Jul 18, 2025
019faba
Commented out potential issues in dataconnect_test.ts
Jul 18, 2025
c4df90c
Added mutationRef's functionality accourding to the api proposal and …
Jul 22, 2025
3f45285
Created two new helper functions that use the executeHelper function.…
Jul 24, 2025
fe78b87
Modified the geturl function to account for a connector being passed …
Jul 31, 2025
1c5e1ce
Replaced some urls present in the executeMutation unit tests and clea…
Aug 1, 2025
c99c078
Incorporated feedback from a PR review and added unit tests for .
Aug 4, 2025
4f8ccdf
Formatted the data-connect-api-client-internals.spec.ts file
Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Formatted the data-connect-api-client-internals.spec.ts file
  • Loading branch information
FOLUSO ONATEMOWO committed Aug 4, 2025
commit 4f8ccdfbd75ff878941dda21e134f2d4d1fc5df3
58 changes: 29 additions & 29 deletions test/unit/data-connect/data-connect-api-client-internal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ describe('DataConnectApiClient', () => {
};

const noProjectId = 'Failed to determine project ID. Initialize the SDK with service '
+ 'account credentials or set project ID as an app option. Alternatively, set the '
+ 'GOOGLE_CLOUD_PROJECT environment variable.';
+ 'account credentials or set project ID as an app option. Alternatively, set the '
+ 'GOOGLE_CLOUD_PROJECT environment variable.';

const TEST_RESPONSE = {
data: {
Expand All @@ -75,7 +75,7 @@ describe('DataConnectApiClient', () => {
location: 'us-west2',
serviceId: 'my-service',
connector: 'mock-connector'
};
};

const clientWithoutProjectId = new DataConnectApiClient(
connectorConfig,
Expand Down Expand Up @@ -232,7 +232,7 @@ describe('DataConnectApiClient', () => {
method: 'POST',
url: `https://firebasedataconnect.googleapis.com/v1alpha/projects/test-project/locations/${connectorConfig.location}/services/${connectorConfig.serviceId}:executeGraphql`,
headers: EXPECTED_HEADERS,
data: { query: 'query' }
data: { query: 'query' }
});
});
});
Expand Down Expand Up @@ -301,7 +301,7 @@ describe('DataConnectApiClient', () => {

describe('executeQuery', () => {
it('should reject when project id is not available', () => {
return clientWithoutProjectIdWithConnector.executeQuery({operationName: 'getById'})
return clientWithoutProjectIdWithConnector.executeQuery({ operationName: 'getById' })
.should.eventually.be.rejectedWith(noProjectId);
});

Expand Down Expand Up @@ -334,7 +334,7 @@ describe('DataConnectApiClient', () => {
.stub(HttpClient.prototype, 'send')
.rejects(utils.errorFrom(ERROR_RESPONSE, 404));
const expected = new FirebaseDataConnectError('not-found', 'Requested entity not found');
return apiClientWithConnector.executeQuery({operationName: 'getById'})
return apiClientWithConnector.executeQuery({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -343,7 +343,7 @@ describe('DataConnectApiClient', () => {
.stub(HttpClient.prototype, 'send')
.rejects(utils.errorFrom({}, 404));
const expected = new FirebaseDataConnectError('unknown-error', 'Unknown server error: {}');
return apiClientWithConnector.executeQuery({operationName: 'getById'})
return apiClientWithConnector.executeQuery({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -353,7 +353,7 @@ describe('DataConnectApiClient', () => {
.rejects(utils.errorFrom('not json', 404));
const expected = new FirebaseDataConnectError(
'unknown-error', 'Unexpected response with status: 404 and body: not json');
return apiClientWithConnector.executeQuery({operationName: 'getById'})
return apiClientWithConnector.executeQuery({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -362,7 +362,7 @@ describe('DataConnectApiClient', () => {
sandbox
.stub(HttpClient.prototype, 'send')
.rejects(expected);
return apiClientWithConnector.executeQuery({operationName: 'getById'})
return apiClientWithConnector.executeQuery({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -379,7 +379,7 @@ describe('DataConnectApiClient', () => {
const stub = sandbox
.stub(HttpClient.prototype, 'send')
.resolves(utils.responseFrom(TEST_RESPONSE, 200));
return apiClientWithConnector.executeQuery<UsersResponse, unknown>({operationName: 'getById'})
return apiClientWithConnector.executeQuery<UsersResponse, unknown>({ operationName: 'getById' })
.then((resp) => {
expect(resp.data.users).to.be.not.empty;
expect(resp.data.users[0].name).to.be.not.undefined;
Expand All @@ -389,7 +389,7 @@ describe('DataConnectApiClient', () => {
method: 'POST',
url: `https://firebasedataconnect.googleapis.com/v1alpha/projects/test-project/locations/${connectorConfig_with_connector.location}/services/${connectorConfig_with_connector.serviceId}/connectors/${connectorConfig_with_connector.connector}:executeQuery`,
headers: EXPECTED_HEADERS,
data: { query: undefined, name: 'getById', operationName: 'getById'}
data: { query: undefined, name: 'getById', operationName: 'getById' }
});
});
});
Expand All @@ -407,7 +407,7 @@ describe('DataConnectApiClient', () => {
const stub = sandbox
.stub(HttpClient.prototype, 'send')
.resolves(utils.responseFrom(TEST_RESPONSE, 200));
return apiClientWithConnector.executeQuery<UsersResponse, unknown>({operationName: 'getById', variables: {} })
return apiClientWithConnector.executeQuery<UsersResponse, unknown>({ operationName: 'getById', variables: {} })
.then((resp) => {
expect(resp.data.users).to.be.not.empty;
expect(resp.data.users[0].name).to.be.not.undefined;
Expand All @@ -417,7 +417,7 @@ describe('DataConnectApiClient', () => {
method: 'POST',
url: `https://firebasedataconnect.googleapis.com/v1alpha/projects/test-project/locations/${connectorConfig_with_connector.location}/services/${connectorConfig_with_connector.serviceId}/connectors/${connectorConfig_with_connector.connector}:executeQuery`,
headers: EXPECTED_HEADERS,
data: { query: undefined, name: 'getById', operationName: 'getById', variables: {} }
data: { query: undefined, name: 'getById', operationName: 'getById', variables: {} }
});
});
});
Expand All @@ -427,21 +427,21 @@ describe('DataConnectApiClient', () => {
const stub = sandbox
.stub(HttpClient.prototype, 'send')
.resolves(utils.responseFrom(TEST_RESPONSE, 200));
return apiClientWithConnector.executeQuery({operationName: 'getById'})
return apiClientWithConnector.executeQuery({ operationName: 'getById' })
.then(() => {
expect(stub).to.have.been.calledOnce.and.calledWith({
method: 'POST',
url: `http://localhost:9399/v1alpha/projects/test-project/locations/${connectorConfig_with_connector.location}/services/${connectorConfig_with_connector.serviceId}/connectors/${connectorConfig_with_connector.connector}:executeQuery`,
headers: EMULATOR_EXPECTED_HEADERS,
data: { query: undefined, name: 'getById', operationName: 'getById' }
data: { query: undefined, name: 'getById', operationName: 'getById' }
});
});
});
});

describe('executeMutation', () => {
it('should reject when project id is not available', () => {
return clientWithoutProjectIdWithConnector.executeMutation({operationName: 'getById'})
return clientWithoutProjectIdWithConnector.executeMutation({ operationName: 'getById' })
.should.eventually.be.rejectedWith(noProjectId);
});

Expand Down Expand Up @@ -474,7 +474,7 @@ describe('DataConnectApiClient', () => {
.stub(HttpClient.prototype, 'send')
.rejects(utils.errorFrom(ERROR_RESPONSE, 404));
const expected = new FirebaseDataConnectError('not-found', 'Requested entity not found');
return apiClientWithConnector.executeMutation({operationName: 'getById'})
return apiClientWithConnector.executeMutation({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -483,7 +483,7 @@ describe('DataConnectApiClient', () => {
.stub(HttpClient.prototype, 'send')
.rejects(utils.errorFrom({}, 404));
const expected = new FirebaseDataConnectError('unknown-error', 'Unknown server error: {}');
return apiClientWithConnector.executeMutation({operationName: 'getById'})
return apiClientWithConnector.executeMutation({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -493,7 +493,7 @@ describe('DataConnectApiClient', () => {
.rejects(utils.errorFrom('not json', 404));
const expected = new FirebaseDataConnectError(
'unknown-error', 'Unexpected response with status: 404 and body: not json');
return apiClientWithConnector.executeMutation({operationName: 'getById'})
return apiClientWithConnector.executeMutation({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -502,7 +502,7 @@ describe('DataConnectApiClient', () => {
sandbox
.stub(HttpClient.prototype, 'send')
.rejects(expected);
return apiClientWithConnector.executeMutation({operationName: 'getById'})
return apiClientWithConnector.executeMutation({ operationName: 'getById' })
.should.eventually.be.rejected.and.deep.include(expected);
});

Expand All @@ -519,7 +519,7 @@ describe('DataConnectApiClient', () => {
const stub = sandbox
.stub(HttpClient.prototype, 'send')
.resolves(utils.responseFrom(TEST_RESPONSE, 200));
return apiClientWithConnector.executeMutation<UsersResponse, unknown>({operationName: 'getById'})
return apiClientWithConnector.executeMutation<UsersResponse, unknown>({ operationName: 'getById' })
.then((resp) => {
expect(resp.data.users).to.be.not.empty;
expect(resp.data.users[0].name).to.be.not.undefined;
Expand All @@ -529,7 +529,7 @@ describe('DataConnectApiClient', () => {
method: 'POST',
url: `https://firebasedataconnect.googleapis.com/v1alpha/projects/test-project/locations/${connectorConfig_with_connector.location}/services/${connectorConfig_with_connector.serviceId}/connectors/${connectorConfig_with_connector.connector}:executeMutation`,
headers: EXPECTED_HEADERS,
data: { query: undefined, name: 'getById', operationName: 'getById'}
data: { query: undefined, name: 'getById', operationName: 'getById' }
});
});
});
Expand All @@ -547,7 +547,7 @@ describe('DataConnectApiClient', () => {
const stub = sandbox
.stub(HttpClient.prototype, 'send')
.resolves(utils.responseFrom(TEST_RESPONSE, 200));
return apiClientWithConnector.executeMutation<UsersResponse, unknown>({operationName: 'getById', variables: {} })
return apiClientWithConnector.executeMutation<UsersResponse, unknown>({ operationName: 'getById', variables: {} })
.then((resp) => {
expect(resp.data.users).to.be.not.empty;
expect(resp.data.users[0].name).to.be.not.undefined;
Expand All @@ -557,7 +557,7 @@ describe('DataConnectApiClient', () => {
method: 'POST',
url: `https://firebasedataconnect.googleapis.com/v1alpha/projects/test-project/locations/${connectorConfig_with_connector.location}/services/${connectorConfig_with_connector.serviceId}/connectors/${connectorConfig_with_connector.connector}:executeMutation`,
headers: EXPECTED_HEADERS,
data: { query: undefined, name: 'getById', operationName: 'getById', variables: {} }
data: { query: undefined, name: 'getById', operationName: 'getById', variables: {} }
});
});
});
Expand All @@ -567,13 +567,13 @@ describe('DataConnectApiClient', () => {
const stub = sandbox
.stub(HttpClient.prototype, 'send')
.resolves(utils.responseFrom(TEST_RESPONSE, 200));
return apiClientWithConnector.executeMutation({operationName: 'getById'})
return apiClientWithConnector.executeMutation({ operationName: 'getById' })
.then(() => {
expect(stub).to.have.been.calledOnce.and.calledWith({
method: 'POST',
url: `http://localhost:9399/v1alpha/projects/test-project/locations/${connectorConfig_with_connector.location}/services/${connectorConfig_with_connector.serviceId}/connectors/${connectorConfig_with_connector.connector}:executeMutation`,
headers: EMULATOR_EXPECTED_HEADERS,
data: { query: undefined, name: 'getById', operationName: 'getById' }
data: { query: undefined, name: 'getById', operationName: 'getById' }
});
});
});
Expand Down Expand Up @@ -708,11 +708,11 @@ describe('DataConnectApiClient CRUD helpers', () => {
.to.be.rejectedWith(FirebaseDataConnectError, /`data` must be a non-null object./);
});

it('should throw FirebaseDataConnectError for array data', async() => {
it('should throw FirebaseDataConnectError for array data', async () => {
await expect(apiClient.insert(tableName, []))
.to.be.rejectedWith(FirebaseDataConnectError, /`data` must be an object, not an array, for single insert./);
});

it('should amend the message for query errors', async () => {
await expect(apiClientQueryError.insert(tableName, { data: 1 }))
.to.be.rejectedWith(FirebaseDataConnectError, `${serverErrorString}. ${additionalErrorMessageForBulkImport}`);
Expand Down
Loading