Skip to content

Conversation

diwu-arete
Copy link
Contributor

No description provided.

@diwu-arete diwu-arete requested a review from vkryachko June 11, 2019 19:08
@googlebot googlebot added the cla: yes Override cla label Jun 11, 2019
@diwu-arete diwu-arete requested a review from shrutip90 June 11, 2019 21:42
@diwu-arete
Copy link
Contributor Author

kindly ping

@vkryachko
Copy link
Member

/retest

@diwu-arete diwu-arete requested review from dmandar and vkryachko June 12, 2019 21:56
Copy link

@dmandar dmandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. You might want to create PRs to merge from arete-floc to arete-floc-master and do one final PR to merge into master once ready.

Copy link

@dmandar dmandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to create PRs to merge from arete-floc to arete-floc-master and do one final PR to merge into master once ready.

@diwu-arete diwu-arete changed the base branch from master to floc-master June 12, 2019 22:34
@diwu-arete
Copy link
Contributor Author

Re mandar: merging this branch to floc-master, good point!

@diwu-arete diwu-arete requested a review from dmandar June 12, 2019 22:46
@diwu-arete
Copy link
Contributor Author

/retest

@diwu-arete
Copy link
Contributor Author

/retest

@diwu-arete diwu-arete merged commit 0d05282 into floc-master Jun 13, 2019
@diwu-arete diwu-arete deleted the arete-floc branch June 13, 2019 00:49
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Override cla size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants