Skip to content

Prepare shutdown to be a public api. #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
11 commits merged into from
Jul 17, 2019
Merged

Prepare shutdown to be a public api. #589

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fa5e624
Deregister firestore when shutdown + app.delete calls shutdown
wu-hui Jul 4, 2019
9ba6ff3
synchronized scheduling + soft shutdown
wu-hui Jul 4, 2019
835ddc8
Add comments and more tests
wu-hui Jul 8, 2019
e7e3ea1
addressing comments #1
wu-hui Jul 11, 2019
317fea7
fixing format in tools
wu-hui Jul 11, 2019
34171e8
Stop leakages
wu-hui Jul 14, 2019
74d507c
better comments
wu-hui Jul 14, 2019
fe02b17
Handle app delete shutdown differently
wu-hui Jul 17, 2019
f8b33ed
No more error-prone hack
wu-hui Jul 17, 2019
d3141b2
Change how to interact with MultiDbComponent.
wu-hui Jul 17, 2019
701fcef
add missing sync keyword
wu-hui Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add missing sync keyword
  • Loading branch information
@wu-hui
wu-hui committed Jul 17, 2019
commit 701fcef2de51f3c117a7168ac1d7cbf3d1757d2c
2 changes: 1 addition & 1 deletion ...base-firestore/src/main/java/com/google/firebase/firestore/FirestoreMultiDbComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public synchronized void remove(@NonNull String databaseId) {
}

@Override
public void onDeleted(String firebaseAppName, FirebaseOptions options) {
public synchronized void onDeleted(String firebaseAppName, FirebaseOptions options) {
// Shuts down all database instances and remove them from registry map when App is deleted.
for (Map.Entry<String, FirebaseFirestore> entry : instances.entrySet()) {
entry.getValue().shutdownInternal();
Expand Down