Retrying firestore integration tests #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinraghav
requested review from
bjornick,
rsgowman,
vkryachko and
wilhuff
|
/test connected-check |
|
/test connected-check |
mikelehen
approved these changes
Sep 10, 2018
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/ArrayTransformsTest.java
Show resolved
Hide resolved
|
Chatted with @wilhuff and @mikelehen offline. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7 @bjornick pointed out that retrying the integration tests might help alleviate some flakiness. I think we should try this and see if the issue surfaces over the next couples of weeks 🤞.
If we find other projects that have similar flakes fixable by retrying, it might make sense to create a shared Gradle module with the
RetryRulethat projects can depend on in theirtestImplementationGradle configs.