Skip to content

Conversation

thatfiredev
Copy link
Member

Should only be merged after the first release of firebase-database-ktx

@google-oss-bot
Copy link
Contributor

Hi @rosariopfernandes. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rlazo
Copy link
Collaborator

rlazo commented Oct 7, 2019

/ok-to-test

@rlazo
Copy link
Collaborator

rlazo commented Oct 16, 2019

Thanks a lot for your contribution @rosariopfernandes!

/cc @rachelsaunders firebase-database-ktx has launched. Could you please check this PR?

https://dl.google.com/dl/android/maven2/com/google/firebase/group-index.xml

@rlazo rlazo merged commit a37f703 into firebase:master Oct 17, 2019
@thatfiredev thatfiredev deleted the rpf.add-database-ktx-docs branch October 17, 2019 19:19
@firebase firebase locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants