Skip to content

fix: crash with InvalidAuthBlockingTokenError #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 16, 2023
Merged

fix: crash with InvalidAuthBlockingTokenError #145

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6fd96fe
fix: crash with InvalidAuthBlockingTokenError (wrong audience)
exaby73 Oct 9, 2023
b56f46c
fix: KeyError when last_sign_in_time does not exist in token_data
exaby73 Oct 9, 2023
8a9c376
refactor: creation_time and last_sign_in_time parsing
exaby73 Oct 9, 2023
ccc4d7e
fix: crash with InvalidAuthBlockingTokenError (wrong audience)
exaby73 Oct 9, 2023
0d84189
fix: KeyError when last_sign_in_time does not exist in token_data
exaby73 Oct 9, 2023
4d93b43
refactor: creation_time and last_sign_in_time parsing
exaby73 Oct 9, 2023
4946c4f
Merge remote-tracking branch 'origin/feat/fix_identify_before_user_cr…
exaby73 Oct 11, 2023
424fb08
fix: line too long lint
exaby73 Oct 11, 2023
e759b1e
fix: type checks and formatting
exaby73 Oct 11, 2023
fdb06b2
Merge remote-tracking branch 'origin' into feat/fix_identify_before_u…
exaby73 Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: crash with InvalidAuthBlockingTokenError (wrong audience)
  • Loading branch information
@exaby73
exaby73 committed Oct 10, 2023
commit ccc4d7e3b32b19383acf7862e4179e78856a42a0
8 changes: 4 additions & 4 deletions src/firebase_functions/private/_identity_fn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ def _auth_user_info_from_token_data(token_data: dict[str, _typing.Any]):

def _auth_user_metadata_from_token_data(token_data: dict[str, _typing.Any]):
from firebase_functions.identity_fn import AuthUserMetadata
creation_time = int(token_data["creation_time"]) / 1000.0
last_sign_in_time = int(token_data["last_sign_in_time"]) / 1000.0
return AuthUserMetadata(
creation_time=_dt.datetime.utcfromtimestamp(
token_data["creation_time"] / 1000.0),
last_sign_in_time=_dt.datetime.utcfromtimestamp(
token_data["last_sign_in_time"] / 1000.0),
creation_time=_dt.datetime.utcfromtimestamp(creation_time),
last_sign_in_time=_dt.datetime.utcfromtimestamp(last_sign_in_time),
)


Expand Down
4 changes: 2 additions & 2 deletions src/firebase_functions/private/token_verifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@ def verify(self, token, request):
'Firebase {0} has incorrect algorithm. Expected "RS256" but got '
'"{1}". {2}'.format(self.short_name, header.get('alg'),
verify_id_token_msg))
elif self.expected_audience and self.expected_audience not in audience:
elif not emulated and self.expected_audience and self.expected_audience not in audience:
error_message = (
'Firebase {0} has incorrect "aud" (audience) claim. Expected "{1}" but '
'got "{2}". {3} {4}'.format(self.short_name,
self.expected_audience, audience,
project_id_match_msg,
verify_id_token_msg))
elif not self.expected_audience and audience != self.project_id:
elif not emulated and not self.expected_audience and audience != self.project_id:
error_message = (
'Firebase {0} has incorrect "aud" (audience) claim. Expected "{1}" but '
'got "{2}". {3} {4}'.format(self.short_name, self.project_id,
Expand Down