Skip to content

fix: Crash in auth blocking function when using with phone auth #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix: Crash in auth blocking function when using with phone auth #146

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2bad15
Blocking login function: fixed crash on phone auth ("email_veried" is…
savytskyi Oct 9, 2023
0001859
Merge branch 'main' into patch-1
taeold Oct 10, 2023
2876bef
Merge branch 'main' into patch-1
taeold Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Blocking login function: fixed crash on phone auth ("email_veried" is… 
… not in the dict)
  • Loading branch information
@savytskyi
savytskyi authored Oct 9, 2023
commit e2bad152c780a336f1e72fac9be104f859a9abf5
2 changes: 1 addition & 1 deletion src/firebase_functions/private/_identity_fn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def _auth_user_record_from_token_data(token_data: dict[str, _typing.Any]):
return AuthUserRecord(
uid=token_data["uid"],
email=token_data.get("email"),
email_verified=token_data["email_verified"],
email_verified=token_data.get("email_verified"),
display_name=token_data.get("display_name"),
photo_url=token_data.get("photo_url"),
phone_number=token_data.get("phone_number"),
Expand Down