Skip to content

fix: incorrect type for document snapshop in Firestore auth triggers #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix: incorrect type for document snapshop in Firestore auth triggers #212

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a274f47
fix: incorrect type for document snapshop in Firestore auth triggers
exaby73 Jul 3, 2024
3fe71df
fix: remove print statement
exaby73 Jul 9, 2024
e5a2323
fix: formatting
exaby73 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: incorrect type for document snapshop in Firestore auth triggers
  • Loading branch information
@exaby73
exaby73 committed Jul 3, 2024
commit a274f474af99c4310fb9b961ab2ef6b014d687f0
11 changes: 8 additions & 3 deletions src/firebase_functions/firestore_fn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,18 @@ def _firestore_endpoint_handler(
firestore_event_data.old_value.create_time,
firestore_event_data.old_value.update_time,
)
if event_type == _event_type_deleted:
print(f"Event type: {event_type}")
if event_type in (_event_type_deleted,
_event_type_deleted_with_auth_context):
firestore_event_data = _typing.cast(_firestore.DocumentEventData,
old_value_snapshot)
if event_type == _event_type_created:
if event_type in (_event_type_created,
_event_type_created_with_auth_context):
firestore_event_data = _typing.cast(_firestore.DocumentEventData,
value_snapshot)
if event_type in (_event_type_written, _event_type_updated):
if event_type in (_event_type_written, _event_type_updated,
_event_type_written_with_auth_context,
_event_type_updated_with_auth_context):
firestore_event_data = _typing.cast(
_firestore.DocumentEventData,
Change(
Expand Down