-
Notifications
You must be signed in to change notification settings - Fork 218
Firebase Functions ships with a binary #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
72c66ef
WIP.
taeold fb5af88
It's v1alpha1
taeold 3c58ff3
Finish writing test. Cleanup.
taeold 5b369f1
Prettier.
taeold 2db4640
Nits.
taeold 306c269
Prettier
taeold f5b0e35
Merge branch 'master' into dl-endpoint-prop
taeold 584ff6d
Unroll v1alpha manifest out of dir.
taeold 11a08fc
Merge branch 'dl-endpoint-prop' of https://github.com/firebase/fireba…
taeold e1d9003
Prefer timeoutSeconds over timeout.
taeold 69a8846
Prefer topic over generic resource.
taeold 8d7cbee
Whoops this shouldn't go.
taeold eb0a9b0
Refactor vpc option.
taeold 105cc7c
Finalize refactor.
taeold 3de212b
Don't transform SA, consistent fn name.
taeold c765db5
Unroll trigger options.
taeold 08cde7a
Make callable its own trigger, fix tests.
taeold fafcbd5
No need for dynamic props.
taeold 7864635
Prettier.
taeold 4ca1d44
Better types.
taeold 3f47fdc
Few more fixes.
taeold 726b4eb
One mo nit.
taeold 5eda9cd
No getters if unncessary.
taeold cec015f
Prettier.
taeold 10f88da
Merge branch 'master' of https://github.com/firebase/firebase-functio…
taeold 11f18e8
Rely on default converter function.
taeold fe43588
Simplify logic for copying vpc options.
taeold 5ed6027
Include parameter name in spec.
taeold 07ba07f
Prettier.
taeold c413494
First pass at runtime w/ only admin endpoint, BREAKING CHANGE.
taeold c02c299
Fix typo.
taeold 745d925
Minor fixes.
taeold 0ed1558
First pass at runtime w/ only admin endpoint, BREAKING CHANGE.
taeold fd544ab
Prettier.
taeold ada97f3
Implement admin server for discovering endpoints.
taeold 8740acc
Fixup deps.
taeold 5e0540d
Modify workflow to compile tsc before running test.
taeold 3e2f747
Fix typo.
taeold 18c2487
Add trailing spaces.
taeold 208dc23
Cleanup test impl.
taeold bb500c3
Annotate function triggers with __endpoint property (#999)
taeold 5f2fa90
Add missing import.
taeold 6e3a026
Endpoint annotation on task queue function.
taeold 58f05dc
Loose ends on endpoint annotation on event triggers.
taeold 24e1d42
Reformat + endpoint annotations for handlerr namespace.
taeold 27c5fca
Add more unit tests.
taeold 2439ad1
Refactor to simplify test code.
taeold 654dd47
Rest of specs.
taeold 8a32230
Prettier.
taeold 64b3572
Backend is stack, extract APIs.
taeold a5e0262
Merge branch 'dl-endoint-prop-2' into dl-ff-runtime
taeold 554a33e
More nits for unnecessary silence trick.
taeold 1430fa5
Extend testing on the loader module.
taeold 995b140
WIP - write better tests.
taeold 9a9f0f0
Merge branch 'dl-endoint-prop-2' into dl-ff-runtime
taeold c2de5b4
Fix broken test
taeold 6f2219c
Better merge strategy for required apis.
taeold 9a2cd47
More of annotate endpoint property for functions (#1009)
taeold 732a8a8
Merge branch 'dl-container-contract' of https://github.com/firebase/f…
taeold 3a0c353
Prettier.
taeold f3297f4
Fix bug merging requiredAPIs, add tests.
taeold 1d61a4c
Remove unnecessary imports.
taeold 2a7d78d
Some style nits.
taeold f756646
It's stack not backend.
taeold fe536d2
Assume current dir if arg is missing.
taeold 20faaea
Prettier.
taeold 5512e15
Merge remote-tracking branch 'origin/master' into dl-ff-runtime
taeold 7560cf4
PR feedbacks.
taeold 7d0be1e
Prettier.
taeold 1510689
Cloud scheduler is needed for both v1 and v2 scheduled fns.
taeold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
It's stack not backend.
- Loading branch information
commit f756646f58f3693ea13b3318a7d7faa2c1378bba
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,9 +26,9 @@ const app = express(); | |
|
|
||
| app.get('/stack.yaml', async (req, res) => { | ||
taeold marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| try { | ||
| const backend = await loadStack(functionsDir); | ||
| const stack = await loadStack(functionsDir); | ||
| res.setHeader('content-type', 'text/yaml'); | ||
| res.send(JSON.stringify(backend)); | ||
| res.send(JSON.stringify(stack)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean.... technically JSON is YAML? |
||
| } catch (e) { | ||
| res | ||
| .status(400) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.