Skip to content

Fix retry in event triggers #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Fix retry in event triggers #1463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d5911d
fix retry in event triggers
colerogers Sep 22, 2023
5acf304
changelog
colerogers Sep 22, 2023
ad23582
fix tests
colerogers Sep 22, 2023
d30cdfb
Merge branch 'master' into colerogers.enable-function-retry
taeold Aug 23, 2024
df1f362
Use nullish coalescing instea of logical or.
taeold Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changelog
  • Loading branch information
@colerogers
colerogers committed Sep 22, 2023
commit 5acf3048654260f57aa7adbd1c547b8bc9984439
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Remove HTTP server shutdown message. (#1457)
- Add features to task queue functions. (#1423)
- Add traces to V2 Firestore trigger logs. (#1440)
- Fix retry in event triggered functions. (#1463)
2 changes: 1 addition & 1 deletion src/v2/providers/tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export function onTaskDispatched<Args = any>(
convertInvoker
);
convertIfPresent(func.__endpoint.taskQueueTrigger, opts, "invoker", "invoker", convertInvoker);
copyIfPresent(func.__endpoint.taskQueueTrigger, opts, "retry", "retry")
copyIfPresent(func.__endpoint.taskQueueTrigger, opts, "retry", "retry");

func.__requiredAPIs = [
{
Expand Down