Skip to content

Make storage bucket parameterizeable. Create const for bucket picker #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Make storage bucket parameterizeable. Create const for bucket picker #1518

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
002b2ea
Make storage bucket parameterizeable. Create const for bucket picker
inlined Jan 31, 2024
e2a221a
Fix linter error
inlined Jan 31, 2024
7cfd89e
Use more specific type
inlined Jan 31, 2024
87cf3b4
Remove unused import
inlined Jan 31, 2024
040415d
Export types that were part of an old spec but are not available on m…
inlined Jan 31, 2024
8e442b9
In for a penny, in for a pound
inlined Jan 31, 2024
5f5554d
Merge branch 'master' into inlined.bucket-params
inlined Feb 2, 2024
a7838f5
Clarify types of select/multiSelect
inlined Feb 7, 2024
a3e47bc
Changelog
inlined Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify types of select/multiSelect
  • Loading branch information
@inlined
inlined committed Feb 7, 2024
commit a7838f5c526474f44978ede7dac5ab41a67ba50c
8 changes: 4 additions & 4 deletions src/params/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,13 +172,13 @@ export class CompareExpression<
type ParamValueType = "string" | "list" | "boolean" | "int" | "float" | "secret";

/** Create a select input from a series of values. */
export function select<T>(options: T[]): SelectInput;
export function select<T>(options: T[]): SelectInput<T>;

/** Create a select input from a map of labels to vaues. */
export function select<T>(optionsWithLabels: Record<string, T>): SelectInput;
export function select<T>(optionsWithLabels: Record<string, T>): SelectInput<T>;

/** Create a select input from a series of values or a map of labels to values */
export function select<T>(options: T[] | Record<string, T>): SelectInput {
export function select<T>(options: T[] | Record<string, T>): SelectInput<T> {
let wireOpts: SelectOptions<T>[];
if (Array.isArray(options)) {
wireOpts = options.map((opt) => ({ value: opt }));
Expand Down Expand Up @@ -216,7 +216,7 @@ export function multiSelect(options: string[] | Record<string, string>): MultiSe
type ParamInput<T> =
| TextInput<T>
| SelectInput<T>
| (T extends unknown[] ? MultiSelectInput : never)
| (T extends string[] ? MultiSelectInput : never)
| (T extends string ? ResourceInput : never);

/**
Expand Down