Skip to content

Add new 2nd gen Firestore auth context triggers #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 4, 2024
Merged

Add new 2nd gen Firestore auth context triggers #1519

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bfc36df
rebasing
blidd-google Apr 1, 2024
b660601
add changelog
blidd-google Feb 1, 2024
1184a58
update docstrings
blidd-google Apr 1, 2024
5204b0d
update docstrings (again)
blidd-google Apr 1, 2024
b28d3d8
export authtype and add comment
blidd-google Apr 1, 2024
0c51861
post rebase
blidd-google Apr 1, 2024
aa8df0f
separate out event type with auth context
blidd-google Apr 3, 2024
c5bda98
Revert "post rebase"
blidd-google Apr 3, 2024
92853d5
post rebase
blidd-google Apr 1, 2024
8c83dd8
Revert "separate out event type with auth context"
blidd-google Apr 3, 2024
3902b80
Ugly type safety (#1548)
inlined Apr 3, 2024
7836601
add oninit tests
blidd-google Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "separate out event type with auth context" 
This reverts commit aa8df0f.
  • Loading branch information
@blidd-google
blidd-google committed Apr 3, 2024
commit 8c83dd8415739c6a3dc824eead6c8ab2e317cca2
68 changes: 0 additions & 68 deletions spec/v2/providers/firestore.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,23 +558,6 @@ describe("firestore", () => {
expect(func.run(true as any)).to.eq(2);
expect(func.__endpoint).to.deep.eq(expectedEp);
});

it("calls init function", async () => {
const event: firestore.RawFirestoreEvent = {
...eventBase,
datacontenttype: "application/json",
data: {
oldValue: null,
value: null,
},
};

let hello;
onInit(() => (hello = "world"));
expect(hello).to.be.undefined;
await firestore.onDocumentWrittenWithAuthContext("path", () => null)(event);
expect(hello).to.equal("world");
});
});

describe("onDocumentCreatedWithAuthContext", () => {
Expand Down Expand Up @@ -622,23 +605,6 @@ describe("firestore", () => {
expect(func.run(true as any)).to.eq(2);
expect(func.__endpoint).to.deep.eq(expectedEp);
});

it("calls init function", async () => {
const event: firestore.RawFirestoreEvent = {
...eventBase,
datacontenttype: "application/json",
data: {
oldValue: null,
value: null,
},
};

let hello;
onInit(() => (hello = "world"));
expect(hello).to.be.undefined;
await firestore.onDocumentCreatedWithAuthContext("path", () => null)(event);
expect(hello).to.equal("world");
});
});

describe("onDocumentUpdatedWithAuthContext", () => {
Expand Down Expand Up @@ -686,23 +652,6 @@ describe("firestore", () => {
expect(func.run(true as any)).to.eq(2);
expect(func.__endpoint).to.deep.eq(expectedEp);
});

it("calls init function", async () => {
const event: firestore.RawFirestoreEvent = {
...eventBase,
datacontenttype: "application/json",
data: {
oldValue: null,
value: null,
},
};

let hello;
onInit(() => (hello = "world"));
expect(hello).to.be.undefined;
await firestore.onDocumentUpdatedWithAuthContext("path", () => null)(event);
expect(hello).to.equal("world");
});
});

describe("onDocumentDeletedWithAuthContext", () => {
Expand Down Expand Up @@ -750,23 +699,6 @@ describe("firestore", () => {
expect(func.run(true as any)).to.eq(2);
expect(func.__endpoint).to.deep.eq(expectedEp);
});

it("calls init function", async () => {
const event: firestore.RawFirestoreEvent = {
...eventBase,
datacontenttype: "application/json",
data: {
oldValue: null,
value: null,
},
};

let hello;
onInit(() => (hello = "world"));
expect(hello).to.be.undefined;
await firestore.onDocumentDeletedWithAuthContext("path", () => null)(event);
expect(hello).to.equal("world");
});
});

describe("getOpts", () => {
Expand Down
Loading